Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract layers module from rpc crate #8163

Merged
merged 9 commits into from
May 11, 2024
Merged

Conversation

rupam-04
Copy link
Contributor

@rupam-04 rupam-04 commented May 8, 2024

Closes #8161

@rupam-04
Copy link
Contributor Author

rupam-04 commented May 9, 2024

@mattsse any updates on this?

Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Cargo.toml Outdated Show resolved Hide resolved
@emhane emhane added the C-debt A section of code is hard to understand or change label May 10, 2024
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
@rupam-04
Copy link
Contributor Author

@emhane any idea why some checks are failing?

@emhane
Copy link
Member

emhane commented May 10, 2024

try locally

rm Cargo.lock
cargo clean
cargo c

then commit the updated lock file, and push. that should do it. @rupam-04

@rupam-04
Copy link
Contributor Author

try locally

rm Cargo.lock
cargo clean
cargo c

then commit the updated lock file, and push. that should do it. @rupam-04

worked, ty

@rupam-04 rupam-04 requested a review from emhane May 11, 2024 12:12
Cargo.toml Outdated Show resolved Hide resolved
@emhane emhane added this pull request to the merge queue May 11, 2024
Merged via the queue into paradigmxyz:main with commit e20cb91 May 11, 2024
29 checks passed
Rjected pushed a commit that referenced this pull request May 21, 2024
Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A section of code is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract layers module from rpc crate
2 participants