New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: owner-aware unique model name constraint #2827
Conversation
40d6fa2
to
98953d8
Compare
98953d8
to
92907a3
Compare
92907a3
to
c4ac351
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2827 +/- ##
==========================================
- Coverage 93.14% 93.09% -0.05%
==========================================
Files 149 150 +1
Lines 6387 6401 +14
==========================================
+ Hits 5949 5959 +10
- Misses 438 442 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks, sorry for not including comments before, that does make it much more understandable |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
As was pointed out in the linked discussion, with permissions added, uniqueness by model name should be owner-aware ie two different owners can have the same tag name. The second
UniqueConstraint
is to handlenull
owner. Also this is enforced via the API when owner is changed using serializer. Hopefully the test coverage is up-to-snuff.Please let me know if I've missed anything as I dabble in the backend world.
Fixes #2802
Type of change
Checklist:
pre-commit
hooks, see documentation.