Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype inclusion of release notes in docs #184

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cburroughs
Copy link
Contributor

  • Treat them as a top level "type" of doc
  • Sidebar sorting is finicky :-/
  • Some friction around when we write the notes versus switch the
    'current' doc version

ref #89

 * Treat them as a top level "type" of doc
 * Sidebar sorting is finicky :-/
 * Some friction around when we write the notes versus switch the
 'current' doc version

ref pantsbuild#89
@cburroughs cburroughs marked this pull request as draft April 2, 2024 20:01
@cburroughs
Copy link
Contributor Author

cc @thejcannon @huonw

Have not used docusaurus before, not sure if this is on the right track.

image

@huonw
Copy link
Contributor

huonw commented Apr 3, 2024

The idea sounds good! Just brainstorming:

  • It'd be good to include this as part of the syncing process (I'm guessing you're not dotting Is/crossing Ts like this until you've got agreement on the direction, which is fine and sensible)
  • It seems like this is going in a direction where every version repeats all of the release notes from all prior versions, which doesn't seem "perfect". I wonder if these could either be:
    • "evergreen", i.e. placed within src/pages and accessible from all versions (but still updated as part of the sync process)
    • "properly" versioned, i.e. each version just has one release notes page, which is the notes for the current series, and the 'normal' version switcher can be used to see the notes for different series (because they're all at the same 2.x/... url, other than the x)
  • Also, did you have any specific questions re docusaurus? (not that I can necessarily help, I'm still learning too 😅 )

@cburroughs
Copy link
Contributor Author

seems like this is going in a direction where every version repeats all of the release notes from all prior versions, which doesn't seem "perfect".

It seems to be good enough for various prominent Python projects so I decided I was okay with it:
https://click.palletsprojects.com/en/6.x/changelog/

But yeah it does feel slightly wonky.

I think evergreen is reasonable, but that makes the syncing inconsistent which might be it's own form of wonkyness?

"properly" versioned, i.e. each version just has one release notes page, which is the notes for the current series, and the 'normal' version switcher can be used to see the notes for different series

I think that's reasonable from an avoiding syncing wonkyness perspective but I'm struggling to visualize a project website that does it that way. It's usually a list.

@thejcannon
Copy link
Member

I think it just being an evergreen page (akin to, and maybe linked from) the versions page is fine.

We can either special case the syncing, or just keep them in this repo and update them here if that's too weird

huonw added a commit to pantsbuild/pants that referenced this pull request Apr 27, 2024
…20847)

As far as I can tell the release notes (formerly
`src/python/pants/notes`) are no longer included in wheel builds, so
they can be considered more "normal" documentation. This moves them, and
stops the classify-changes script from flagging them as a
`release`-level change; they'll now just be `docs`.

The pantsbuild.org sync_docs workflow copies the `docs/docs` directory,
so won't be automatically including these... but maybe
pantsbuild/pantsbuild.org#184 will change this
(that PR needs changes, after this).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants