Skip to content

Commit

Permalink
Ignore RUSTSEC-2019-0003. (#7766)
Browse files Browse the repository at this point in the history
We have a fix in-flight in
pantsbuild/rust-protobuf#2 that will still need
this `--ignore` even when we're consuming it. Adding the `--ignore` now
silences nightly CRON audit noise in the meantime and going forward
until we can upgrade to a public official release of protobuf with the
`RUSTSEC-2019-0003` fix.

Part of fixing #7760
  • Loading branch information
jsirois committed May 20, 2019
1 parent 59d249a commit 91a88ba
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions build-support/bin/ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,19 @@ fi
if [[ "${run_cargo_audit:-false}" == "true" ]]; then
start_travis_section "CargoAudit" "Running cargo audit on rust code"
(
"${REPO_ROOT}/build-support/bin/native/cargo" ensure-installed --package=cargo-audit --version=0.5.2
"${REPO_ROOT}/build-support/bin/native/cargo" audit -f "${REPO_ROOT}/src/rust/engine/Cargo.lock"
# TODO(John Sirois): Kill --git-url/--git-rev when we upgrade to cargo-audit > 0.6.1.
# See: https://github.com/pantsbuild/pants/issues/7760 for context.
"${REPO_ROOT}/build-support/bin/native/cargo" ensure-installed \
--package=cargo-audit \
--version=0.6.1 \
--git-url=https://github.com/RustSec/cargo-audit \
--git-rev=1c298bcda2c74f4a1bd8f0d8482b3577ee94fbb3
# TODO(John Sirois): Kill --ignore RUSTSEC-2019-0003 when we can upgrade to an official released
# version of protobuf with a fix.
# See: https://github.com/pantsbuild/pants/issues/7760 for context.
"${REPO_ROOT}/build-support/bin/native/cargo" audit \
-f "${REPO_ROOT}/src/rust/engine/Cargo.lock" \
--ignore RUSTSEC-2019-0003
) || die "Cargo audit failure"
end_travis_section
fi
Expand Down

0 comments on commit 91a88ba

Please sign in to comment.