Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing codecoverage reports #624

Merged
merged 6 commits into from Sep 23, 2018
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Sep 22, 2018

New pytest-cov seems to be handling combining?

pytest-dev/pytest-cov#222

Edit: seems to just be that travis or codecov no longer recognize the bash construct in .travis.yml.

Trying to add the coveragerc specifically.
Reverting to base coverage to see if new pytest-cov works.
@codecov
Copy link

codecov bot commented Sep 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@4f0cb0e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #624   +/-   ##
==========================================
  Coverage           ?   69.26%           
==========================================
  Files              ?       65           
  Lines              ?     5698           
  Branches           ?      807           
==========================================
  Hits               ?     3947           
  Misses             ?     1533           
  Partials           ?      218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0cb0e...84ecf6c. Read the comment docs.

Try to always upload to codecov
Testing with the combining added back in but without the `if`
Removing whitespace change.
@wtgee wtgee merged commit 22c3e21 into panoptes:develop Sep 23, 2018
@wtgee wtgee deleted the coverage-check branch September 23, 2018 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant