Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix encoding error for windows #6

Merged
merged 2 commits into from Jun 3, 2019
Merged

fix encoding error for windows #6

merged 2 commits into from Jun 3, 2019

Conversation

Noordsestern
Copy link
Contributor

On windows installation python may assume a limited encoding such as cp1252. That leads to encoding errors when installing on windows command line, because the README.rst is parsed which as a modern encoding.

This pull requests sets the encoding of the README.rst to UTF-8.

Be aware, that I set a new version 0.8.1, Check, if you want to accept that.

@Noordsestern
Copy link
Contributor Author

This is supposed to fix #5

@Noordsestern
Copy link
Contributor Author

Tested on my local machine with

pip install .

@amotl amotl merged commit bae3111 into panodata:master Jun 3, 2019
@amotl
Copy link
Member

amotl commented Jun 3, 2019

Dear @Noordsestern,

thanks for writing in and thanks for your contribution.

As that would croak on Python 2.x with

Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    README = open(os.path.join(here, 'README.rst'), encoding='UTF-8').read()
TypeError: 'encoding' is an invalid keyword argument for this function

we improved that slightly to satisfy the installation on Python 2.x again by 1315d16. Release 0.8.2 should be on PyPI already. Thanks again!

With kind regards,
Andreas.


P.S.:

Be aware, that I set a new version 0.8.1, Check, if you want to accept that.

Better send pull requests without such version bumps as it is usually done by the upstream machinery in any way, often automagically after running through some build pipeline these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants