Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: fall back to LeastTasks when RoundRobin can't find a worker #306

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

panjf2000
Copy link
Owner

No description provided.

Besides, update a few comments and add new benchmarks for multi-pool
@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (19bd1ea) 91.28% compared to head (6da5c0a) 90.54%.

Files Patch % Lines
multipool.go 60.00% 4 Missing ⚠️
multipool_func.go 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #306      +/-   ##
==========================================
- Coverage   91.28%   90.54%   -0.74%     
==========================================
  Files          11       11              
  Lines         929      941      +12     
==========================================
+ Hits          848      852       +4     
- Misses         60       68       +8     
  Partials       21       21              
Flag Coverage Δ
unittests 90.54% <60.00%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit fb82167 into dev Nov 21, 2023
11 of 13 checks passed
@panjf2000 panjf2000 deleted the multi-pool-opt branch November 21, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant