feat: add a new API ReleaseTimeout for the default pool
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add a new API like |
panjf2000
added
waiting for response
|
I added a function called ReleaseTimeout() to ants.go. Is that what you had in mind? |
panjf2000
requested changes
Jun 29, 2023
…n defaultAntsPool and test new function
panjf2000
changed the title
ReleaseTimeout for the default pool
panjf2000
added
enhancement
panjf2000
requested changes
Jun 29, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 92.44% 92.46% +0.01%
==========================================
Files 9 9
Lines 768 770 +2
==========================================
+ Hits 710 712 +2
Misses 44 44
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
panjf2000
added a commit
that referenced
this pull request
Jun 30, 2023
…)" This reverts commit b3f3a38.
|
I did not check carefully before, we've changed the default branch from |
|
Please open a new pull request to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Unblock goPurge and goTicktock in defaultAntsPool
about: ants.Release() calls defaultAntsPool.Release() which leaves goPurge and goTicktock still running in the background. ants.Release() should close the context for goPurge and goTicktock. This can be accomplished by calling defaultAntsPool.ReleaseTimeout().
title: 'Unblock goPurge and goTicktock in defaultAntsPool'
labels: ''
assignees: ''
1. Are you opening this pull request for bug-fixs, optimizations or new feature?
Bug-fix.
2. Please describe how these code changes achieve your intention.
goPurge and goTicktock are left on the stack because there is no way to close those methods started by the defaultAntsPool. This PR should add a fix for that.
3. Please link to the relevant issues (if any).
#244
4. Which documentation changes (if any) need to be made/updated because of this PR?
4. Checklist