add support for Run(ctx) interface #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panjf2000
added
enhancement
|
kind of busy these days, I will review this PR a few days later, thanks. |
hawkingrei
reviewed
Sep 14, 2022
README.md
Outdated
| @@ -92,6 +92,16 @@ func demoFunc() { | |||
| fmt.Println("Hello World!") | |||
| } | |||
|
|
|||
| type run struct { | |||
| i int32 | |||
| wg *sync.WaitGroup | |||
There was a problem hiding this comment.
@hawkingrei
Yes, found this formatting issue.
Since it's a markdown file, I fixed it manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Add support for Run(ctx) interface
1. Are you opening this pull request for bug-fixs, optimizations or new feature?
yes
This is a pr for interface
Run(ctx)support2. Please describe how these code changes achieve your intention.
NewPoolWithRunnerhas been added.Can support
submitany that implements the Runner interface3. Please link to the relevant issues (if any).
4. Which documentation changes (if any) need to be made/updated because of this PR?
ants_test.go
pool_run.go
worker_run.go
run.go
4. Checklist