Add a new method -- ReleaseWaitAllWorkersExit() for waiting all worke… #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs to exit Signed-off-by: cui fliter <imcusg@gmail.com>
panjf2000
reviewed
Aug 8, 2022
| p.stopHeartbeat = nil | ||
| p.Release() | ||
|
|
||
| for { |
There was a problem hiding this comment.
这里有一个风险，如果某一个 worker 里的任务阻塞了，则这里就永远无法退出了。
There was a problem hiding this comment.
另外，其实你这里的代码和 ReleaseTimeout(timeout) 基本是一样的，我更倾向于直接修改 ReleaseTimeout(timeout)，当 timeout < 0 的时候，就一直等到所有 workers 退出才结束，这样也不用新加一个 API 了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #244