Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting task supports passing in arguments #234

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hanfezh
Copy link

@hanfezh hanfezh commented Jun 29, 2022


name: Pull request
about: Support passing in arguments to sumit task
title: ''
labels: ''
assignees: ''

1. Are you opening this pull request for bug-fixs, optimizations or new feature?

New feature.

2. Please describe how these code changes achieve your intention.

Support dynamic parameters when submitting task.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

@panjf2000
Copy link
Owner

Why do we need this?

Moreover, using any makes ants incompatible with the go versions before 1.18.

@panjf2000 panjf2000 added the waiting for response waiting for the response from commenter label Jun 30, 2022
@hanfezh
Copy link
Author

hanfezh commented Jun 30, 2022

Why do we need this?

Moreover, using any makes ants incompatible with the go versions before 1.18.

It's more convenient and flexible than PoolWithFunc. And replace any with interface{}.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (32664cb) 92.46% compared to head (fa93833) 92.25%.
Report is 62 commits behind head on master.

Files Patch % Lines
ants.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   92.46%   92.25%   -0.22%     
==========================================
  Files           9        9              
  Lines         717      723       +6     
==========================================
+ Hits          663      667       +4     
- Misses         41       43       +2     
  Partials       13       13              
Flag Coverage Δ
unittests 92.25% <77.77%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response waiting for the response from commenter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants