bug: avoid overflow when computing mid in the binarySearch of the wor…

…kerStack (#278)
panjf2000 · Jun 8, 2023 · 67b3a7a · 67b3a7a
1 parent 9fdd99a
commit 67b3a7a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/worker_stack.go b/worker_stack.go
@@ -61,9 +61,8 @@ func (wq *workerStack) refresh(duration time.Duration) []worker {
 }
 
 func (wq *workerStack) binarySearch(l, r int, expiryTime time.Time) int {
-	var mid int
 	for l <= r {
-		mid = (l + r) / 2
+		mid := int(uint(l+r) >> 1) // avoid overflow when computing mid
 		if expiryTime.Before(wq.items[mid].lastUsedTime()) {
 			r = mid - 1
 		} else {