CLN: Changed the behavior of Series.__[gs]etitem__ with an integer slice on objects with a floating-dtype index to a positional instead of label-based slicing
#58449
+29
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/indexes/base.py
Outdated
| "use obj.loc[i:j] instead", | ||
| FutureWarning, | ||
| stacklevel=find_stack_level(), | ||
| raise TypeError( |
There was a problem hiding this comment.
It’s not unsupported. The point is to change the behavior to not special-case here
There was a problem hiding this comment.
Thanks for helping me with this PR. I corrected my mistake, fixed tests, and added a note to v3.0.0
There was a problem hiding this comment.
@jbrockmendel could you please take a look at my changes?
natmokval
changed the title
Series.__[gs]etitem__ Enforce with an integer slice on objects with a floating-dtype index to a positional instead of label-based slicing
natmokval
changed the title
Series.__[gs]etitem__ Enforce with an integer slice on objects with a floating-dtype index to a positional instead of label-based slicingSeries.__[gs]etitem__ with an integer slice on objects with a floating-dtype index to a positional instead of label-based slicing
natmokval
added
Clean
Indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #53338
Changed the behavior of
Series.__getitem__,Series.__setitem__,DataFrame.__getitem__,DataFrame.__setitem__with an integer slice on objects with a floating-dtype index to a positional instead of label-based slicing