Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add jsonline output format in to_dict(), failing type checks #58448

Closed
wants to merge 1 commit into from

Conversation

yukitakah
Copy link

I got stuck and this is incomplete. Maybe it's not a great thing to do returning string in to_dict() functions.

@Aloqeely
Copy link
Contributor

Aloqeely commented Apr 26, 2024

Thanks for the contribution! As mentioned in the original issue, this is already doable with DataFrame.to_json(orient='records', lines=True), and DataFrame.to_dict should only be returning a dictionary value and not a string (hence the name), so it doesn't make sense to implement it here

@WillAyd
Copy link
Member

WillAyd commented Apr 28, 2024

I agree with @Aloqeely - this should already be implemented via .to_json so no reason to duplicate that here

@WillAyd WillAyd closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: adding jsonline output format
3 participants