Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adds errors parameter to array strftime to enhance exception handling. #58445

Closed
wants to merge 34 commits into from

Conversation

StanO1225
Copy link

@StanO1225 StanO1225 commented Apr 26, 2024

  • closes ENH: Better error handling in strftime #58178
  • Tests added and passes in pandas\tests\arrays\test_datetimelike.py
  • Pre-commit passes
  • Added type annotations for new 'errors' parameter in changed strftime functions.
  • Added an entry in the latest doc/source/whatsnew/v3.0.0.rst file in the enhancement section.

jocelyn-morningstar and others added 26 commits April 21, 2024 16:20
@StanO1225 StanO1225 requested a review from WillAyd as a code owner April 26, 2024 20:24
@mroeschke
Copy link
Member

Thanks for the PR, but the original enhancement request hasn't gotten enough feedback from the core team to move forward yet so closing this PR for now. If the original issue gains more support we can reopen this PR

@mroeschke mroeschke closed this Apr 29, 2024
@StanO1225
Copy link
Author

Hi, thank you for looking at the PR. Are there any specific concerns with the way we are handling this issue or does the team just need more time to discuss if it is necessary? Thank you for the update.

@mroeschke
Copy link
Member

The team just needs more time to discuss the original enhancement request. i.e. if an enhancement issue has Needs Triage or Needs Discussion labels, it is not suitable to open a PR yet

@StanO1225
Copy link
Author

I see. Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Better error handling in strftime
5 participants