pd.eval: Series names are now preserved even for "numexpr" engine.
#58437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Series names are now preserved even when using numexpr engine. Making the behavior consistent with python engine.
mroeschke
reviewed
Apr 29, 2024
mroeschke
reviewed
Apr 29, 2024
mroeschke
reviewed
Apr 29, 2024
mroeschke
reviewed
Apr 29, 2024
Comment on lines
+209
to
+210
| return typ(obj, dtype=res_t, **axes) | ||
| return typ(obj, dtype=res_t, name=name, **axes) |
There was a problem hiding this comment.
Shouldn't name=None also be OK? i.e. Can't this always be return typ(obj, dtype=res_t, name=name, **axes)?
There was a problem hiding this comment.
Unfortunately no. In some cases typ is DataFrame (in particular cases like pd.eval("df + df")) in which case passing anything as name= (including None) would raise a TypeError
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
mroeschke
approved these changes
Apr 29, 2024
|
Thanks @domsmrz |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…ne. (pandas-dev#58437) * Eval: Series names are preserved for numexpr Series names are now preserved even when using numexpr engine. Making the behavior consistent with python engine. * Update doc/source/whatsnew/v3.0.0.rst Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> * Update pandas/core/computation/align.py Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> * Update pandas/tests/computation/test_eval.py --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series names are now preserved even when using
numexpr engine. Making the behavior consistent
with python engine.
DataFrame.eval#58069)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.