BUG: identity checking NA in map incorrect #58392
Open
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droussea2001
changed the title
|
@mroeschke: Hello, hope you're doing well, would it be possible to merge this PR or should I propose another approach ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapis incorrect #57390doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.The idea is just to avoid that
pd.NAvalue are converted tonp.nanby callingto_numpy:pd.NAvalues staypd.NAvalues after amapoperationThat's why
test_mapandtest_map_na_action_ignorewere modified in this way (we expect in this modified tests to keeppd.NAafter amap)@mroeschke: would it be acceptable to manage this problem in this way ?