Test dir of pandas.api.* #52826
Merged
Test dir of pandas.api.* #52826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
rhshadrach
requested changes
Apr 22, 2023
pandas/tests/api/test_api.py
Outdated
| @@ -17,10 +23,12 @@ def check(self, namespace, expected, ignored=None): | |||
| result = sorted( | |||
| f for f in dir(namespace) if not f.startswith("__") and f != "annotations" | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Can you remove this added line. I think the code is fine either way (someone could argue to remove the blank lines with the justification that they unnecessarily use up vertical space), and in such cases it's best to leave as-is.
There was a problem hiding this comment.
Absolutely, thank you for the review. Implemented all the changes.
pandas/tests/api/test_api.py
Outdated
| if ignored is not None: | ||
| result = sorted(set(result) - set(ignored)) | ||
|
|
||
| expected = sorted(expected) | ||
|
|
pandas/tests/api/test_api.py
Outdated
| @@ -237,8 +245,14 @@ def test_depr(self): | |||
|
|
|||
|
|
|||
| class TestApi(Base): | |||
| allowed = ["types", "extensions", "indexers", "interchange", "typing"] | |||
| allowed_typing = [ | |||
| allowed_api_dirs: list[str] = [ | |||
There was a problem hiding this comment.
By-and-large, we do not type-hint test code. I think we should keep the status-quo here unless an explicit decision is made to add type-hints. Can you remove throughout.
|
Thanks @SecretLake! |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rhshadrach Could you please review this PR?