Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Fix dark mode styles #50936

Merged
merged 4 commits into from Mar 9, 2023
Merged

DOC: Fix dark mode styles #50936

merged 4 commits into from Mar 9, 2023

Conversation

anushkabishnoi
Copy link
Contributor

@anushkabishnoi anushkabishnoi commented Jan 23, 2023 •
edited by datapythonista

closes #48527

@anushkabishnoi
dark mode styles fixed
16ac4a4 
Signed-off-by: Anushka Bishnoi <anushkabishnoi9@gmail.com>
@mroeschke
Copy link
Member

Is this in reference to an existing Github issue?

tuhinmallick
tuhinmallick reviewed Jan 23, 2023
View reviewed changes
doc/source/_static/css/getting_started.css
@@ -236,7 +236,7 @@ ul.task-bullet > li > p:first-child {

.tutorial-card .card-header {
cursor: pointer;
background-color: white;
background-color: transparent;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to #48527 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is, sorry for not mentioning this (first timer here)

@anushkabishnoi
Copy link
Contributor Author

Is this in reference to an existing Github issue?

yes, it's in reference to #42744
just realising I should've mentioned that, sorry for the misunderstanding

@tuhinmallick
Copy link

It is already closed

@anushkabishnoi
Copy link
Contributor Author

It is already closed

But there was a portion of the site still not corrected, ans that's what I modified. The issue is still open because of that.

@datapythonista datapythonista changed the title fixing dark mode styles WEB: Fix dark mode styles Feb 2, 2023
@datapythonista datapythonista added the Web pandas website label Feb 2, 2023
@datapythonista
Copy link
Member

Preview docs at: https://pandas.pydata.org/preview/50936/

@datapythonista
Copy link
Member

Thanks @anushkabishnoi for working on this.

Looks like the collapsed blocks are fixed by this, but when you expand it still has white background: https://pandas.pydata.org/preview/50936/docs/getting_started/index.html

Do you want to have a look and see if you can also fix that?

@datapythonista datapythonista added Docs and removed Web pandas website labels Feb 2, 2023
@datapythonista datapythonista changed the title WEB: Fix dark mode styles DOC: Fix dark mode styles Feb 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Mar 5, 2023
@datapythonista
Copy link
Member

@anushkabishnoi do you have time to address the comments above?

@anushkabishnoi
Copy link
Contributor Author

hey I'm sorry for not responding earlier, I tried to work out the other thing you pointed out, and I can't seem to figure it out.
Is it fine if we just merge the original pr, or do i try the other thing again?

Thanks in advance.

@datapythonista
Copy link
Member

What's the exact problem? Seems like it should just be repeating what you did to the style of the other component.

@PKNaveen PKNaveen mentioned this pull request Mar 8, 2023
Closed
PKNaveen
PKNaveen suggested changes Mar 8, 2023
View reviewed changes
Copy link

@PKNaveen PKNaveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove the white background while expanding replace line 242 with this

.tutorial-card .card-body {
  background-color: #F0F0F0;
  background-color: transparent;
}

@PKNaveen
Copy link

PKNaveen commented Mar 8, 2023 •
edited

To remove the white background while expanding replace line 242 with this

.tutorial-card .card-body {
  background-color: #F0F0F0;
  background-color: transparent;
}

"What kind of data does pandas handle?" This Expansion Box contains an image with black Font here I am not sure if this is a style problem or the image. If there are no other problems this issue should be solved.

@anushkabishnoi
Update getting_started.css
ddfaf3c 
Signed-off-by: Anushka Bishnoi <anushkabishnoi9@gmail.com>
@anushkabishnoi
Copy link
Contributor Author

I've pushed a commit, the only issue still prevailing - the text on the svg needs to change with dark and light modes. I don't have eperience working with SVGs, so if you guys can help me out, that would be great.

(this is what I mentioned not being able to figure out)

datapythonista
datapythonista reviewed Mar 8, 2023
View reviewed changes
doc/source/_static/css/getting_started.css Outdated
@@ -236,11 +236,12 @@ ul.task-bullet > li > p:first-child {

.tutorial-card .card-header {
cursor: pointer;
background-color: white;
background-color: transparent;
}

.tutorial-card .card-body {
background-color: #F0F0F0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this line please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change isn't being acknowledged as a modification, so it's not commiting (working tree clean)

@datapythonista
Copy link
Member

Deleted the line myself. So far doesn't seem to be working, let's see if with this new change: https://pandas.pydata.org/preview/50936/docs/getting_started/index.html

Would be good to test things locally, since the CI is not very fast.

@datapythonista datapythonista added this to the 2.0 milestone Mar 9, 2023
@datapythonista datapythonista mentioned this pull request Mar 9, 2023
Closed
datapythonista
datapythonista approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like removing the original line worked, this is working now. https://pandas.pydata.org/preview/50936/docs/getting_started/index.html

@datapythonista datapythonista mentioned this pull request Mar 9, 2023
Closed
1 task
@mroeschke mroeschke merged commit f4f2d89 into pandas-dev:main Mar 9, 2023
@mroeschke
Copy link
Member

Thanks @anushkabishnoi

@meeseeksmachine meeseeksmachine mentioned this pull request Mar 9, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 9, 2023
@anushkabishnoi @meeseeksmachine
Backport PR pandas-dev#50936: DOC: Fix dark mode styles
88d2e30
mroeschke pushed a commit that referenced this pull request Mar 9, 2023
@meeseeksmachine @anushkabishnoi
Backport PR #50936 on branch 2.0.x (DOC: Fix dark mode styles) (#51864)
9c9e9a5 
Backport PR #50936: DOC: Fix dark mode styles

Co-authored-by: Anushka Bishnoi <anushkabishnoi9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuhinmallick tuhinmallick tuhinmallick left review comments

@PKNaveen PKNaveen PKNaveen requested changes

@datapythonista datapythonista datapythonista approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

DOC: Fix styles for dark mode in docs home
5 participants
@anushkabishnoi @mroeschke @tuhinmallick @datapythonista @PKNaveen