API: Harmonize dtype for index levels for Series.sparse.from_coo #50926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
Series.sparse.from_coo
branch
from
e01ae12
to
7a9206a
Compare
|
The failure looks unrelated. |
mroeschke
approved these changes
Jan 23, 2023
|
Thanks @topper-123 |
pooja-subramaniam
pushed a commit
to pooja-subramaniam/pandas
that referenced
this pull request
Jan 25, 2023
…das-dev#50926) * API: Harmonize dtype for index levels for Series.sparse.from_coo * add gh number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the levels of the index the sparse series has different dtype (int32 or int64), depending on if the
dense_indexis true or False. This PR makes the dtype to be always int32, the same as the row/col attributes of the scipycoo_matrix.See also discussion here: #49560 (comment).