Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #49615 on branch 1.5.x (REGR: Better warning in pivot_table when dropping nuisance columns) #50701

Conversation

MarcoGorelli
Copy link
Member

… nuisance columns

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Warnings Warnings that appear or should be added to pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply labels Jan 12, 2023
@MarcoGorelli MarcoGorelli added this to the 1.5.3 milestone Jan 12, 2023
@phofl
Copy link
Member

phofl commented Jan 12, 2023

I think this was taken care of by #49653 but label was not removed

@MarcoGorelli
Copy link
Member Author

yeah just saw that 😄

@phofl
Copy link
Member

phofl commented Jan 12, 2023

We should be more strict in linking the backport pr to the original pr, this is really hard to see like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Reshaping Concat, Merge/Join, Stack/Unstack, Explode Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants