Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Fix the Styler user guide table width issues #49811

Merged
merged 1 commit into from Nov 22, 2022
Merged

DOC: Fix the Styler user guide table width issues #49811

merged 1 commit into from Nov 22, 2022

Conversation

attack68
Copy link
Contributor

Not sure if this has any other unintended consequences. Note that "auto" is the default table width setting in CSS when unspecified. This was the previous setting until 1.5.0 and an update to pydata-sphinx-theme seems to have changed this setting.

Would like to check the rendered output to make sure this affects as expected.

@attack68
DOC: Fix the Styler user guide table width issues
c9f9201 
Not sure if this has any other unintended consequences. Note that "auto" is the default table width setting in CSS when unspecified. This was the previous setting until 1.5.0 and an update to pydata-sphinx-theme seems to have changed this setting.
@attack68 attack68 mentioned this pull request Nov 21, 2022
Merged
6 tasks
@mroeschke mroeschke added Docs Web pandas website labels Nov 21, 2022
@phofl
Copy link
Member

phofl commented Nov 21, 2022

Did it work locally?

@attack68
Copy link
Contributor Author

y

@phofl phofl merged commit 9691bba into main Nov 22, 2022
@phofl phofl added this to the 1.5.3 milestone Nov 22, 2022
@phofl
Copy link
Member

phofl commented Nov 22, 2022 •
edited

@meeseeksdev backport 1.5.x

1 similar comment
@phofl
Copy link
Member

phofl commented Nov 22, 2022

@meeseeksdev backport 1.5.x

@meeseeksmachine meeseeksmachine mentioned this pull request Nov 22, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Nov 22, 2022
@attack68 @meeseeksmachine
Backport PR pandas-dev#49811: DOC: Fix the Styler user guide table wi…
e2aadc8 
…dth issues
@phofl
Copy link
Member

phofl commented Nov 22, 2022

thx @attack68

@mroeschke mroeschke deleted the attack68-patch-1 branch November 22, 2022 17:25
phofl pushed a commit that referenced this pull request Nov 22, 2022
@meeseeksmachine @attack68
Backport PR #49811 on branch 1.5.x (DOC: Fix the Styler user guide ta…
b7558b6 
…ble width issues) (#49841)

Backport PR #49811: DOC: Fix the Styler user guide table width issues

Co-authored-by: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@attack68 @mliu08
DOC: Fix the Styler user guide table width issues (pandas-dev#49811)
db0db9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

@datapythonista datapythonista Awaiting requested review from datapythonista

Assignees
No one assigned
Labels
Docs Web pandas website
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.

DOC: Sticky Headers in Table Visualization is broken in v1.5.0
3 participants
@attack68 @phofl @mroeschke