TST: test UInt64Index in tests/indexes/interval/test_constructors.py #49786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
interval_test_constructors
branch
from
a75f443
to
2153c84
Compare
mroeschke
added
Testing
mroeschke
reviewed
Nov 23, 2022
| @@ -38,25 +40,41 @@ class ConstructorTests: | |||
| get_kwargs_from_breaks to the expected format. | |||
| """ | |||
|
|
|||
| def _skip_test_constructor(self, dtype): | |||
| # get_kwargs_from_breaks in TestFromTuples and TestClassconstructors just return | |||
| # tuples of ints, so IntervalIndex can't know the original dtype | |||
There was a problem hiding this comment.
Is the tuple of ints key for the constructor tests or can they be cast to an array where the dtype is known?
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UInt64Indexwasn't tested previously in theIntervalIndexconstructor tests, this adds tests for that.Preparation for fixing an issue in #49560.