Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add 'color' and 'size' to arguments (#44856)" #49734

Merged
merged 2 commits into from Nov 17, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 16, 2022

cc @MarcoGorelli would you be ok with reverting?

This reverts commit 8a4abfa.

# Conflicts:
#	doc/source/whatsnew/v1.5.0.rst
#	pandas/plotting/_core.py
#	pandas/tests/plotting/frame/test_frame_color.py
@MarcoGorelli
Copy link
Member

yeah should be fine 👍

@mroeschke mroeschke added the Visualization plotting label Nov 17, 2022
@phofl phofl added this to the 1.5.2 milestone Nov 17, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @MarcoGorelli merge when ready

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks @phofl

@MarcoGorelli MarcoGorelli merged commit 961005a into pandas-dev:main Nov 17, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Nov 17, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

@MarcoGorelli
Copy link
Member

@meeseeksdev backport 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 17, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

@MarcoGorelli
Copy link
Member

don't know what's up with meeseeksdev, but I've done this manually in #49752

@phofl phofl deleted the revert_color_alias branch November 17, 2022 21:08
MarcoGorelli pushed a commit to MarcoGorelli/pandas that referenced this pull request Nov 18, 2022
…as-dev#49734)

* Revert "Add 'color' and 'size' to arguments (pandas-dev#44856)"

This reverts commit 8a4abfa.

# Conflicts:
#	doc/source/whatsnew/v1.5.0.rst
#	pandas/plotting/_core.py
#	pandas/tests/plotting/frame/test_frame_color.py

* Add whatsnew
twoertwein pushed a commit to twoertwein/pandas that referenced this pull request Nov 20, 2022
…as-dev#49734)

* Revert "Add 'color' and 'size' to arguments (pandas-dev#44856)"

This reverts commit 8a4abfa.

# Conflicts:
#	doc/source/whatsnew/v1.5.0.rst
#	pandas/plotting/_core.py
#	pandas/tests/plotting/frame/test_frame_color.py

* Add whatsnew
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
…as-dev#49734)

* Revert "Add 'color' and 'size' to arguments (pandas-dev#44856)"

This reverts commit 8a4abfa.

# Conflicts:
#	doc/source/whatsnew/v1.5.0.rst
#	pandas/plotting/_core.py
#	pandas/tests/plotting/frame/test_frame_color.py

* Add whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants