Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Enforce dropping of datetime in DataFrame.mean/median with numeric_only=None #49384

Closed
wants to merge 1 commit into from
Closed

DEPR: Enforce dropping of datetime in DataFrame.mean/median with numeric_only=None #49384

wants to merge 1 commit into from

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@rhshadrach rhshadrach added Deprecate Functionality to remove in pandas DataFrame DataFrame data structure Reduction Operations sum, mean, min, max, etc. Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply labels Oct 29, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Oct 29, 2022
@jbrockmendel
Copy link
Member

#49250 addresses this but interprets it the opposite way

@rhshadrach
Copy link
Member Author

Ah, I thought I checked the queue but must have missed yours.

but interprets it the opposite way

Not sure what you mean by this, they seem pretty compatible to me. Comparing them, I see now I removed a warning that shouldn't have been. Closing in favor of yours.

@rhshadrach rhshadrach closed this Oct 29, 2022
@rhshadrach rhshadrach deleted the enforce_mean_median_datetime branch April 2, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DataFrame DataFrame data structure Deprecate Functionality to remove in pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhshadrach @jbrockmendel