New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Avoid call to list in isin #49192

Merged

phofl merged 1 commit into pandas-dev:main from rhshadrach:isin_perf_followup

Oct 20, 2022

Member

rhshadrach commented Oct 20, 2022 •

edited

closes #xxxx (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Noticed this after #49162 was merged. Likely makes very little difference unless values is huge.


          PERF: Avoid call to list in isin

cf747bf

rhshadrach added Performance Algos labels

rhshadrach requested a review from phofl

October 20, 2022 03:11

phofl added this to the 2.0 milestone

phofl approved these changes

View reviewed changes

phofl merged commit 14b2b61 into pandas-dev:main

Member

phofl commented Oct 20, 2022

thx @rhshadrach

rhshadrach deleted the isin_perf_followup branch

October 20, 2022 10:41

noatamir pushed a commit to noatamir/pandas that referenced this pull request


          PERF: Avoid call to list in isin (pandas-dev#49192)

f9e0dba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment