BUG: to_datetime(..., infer_datetime_format=True) fails with np.str_input #48970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Oct 6, 2022
Comment on lines
-967
to
-968
| if not isinstance(dt_str, str): | ||
| return None |
There was a problem hiding this comment.
no longer necessary, as the input is typed as : str
MarcoGorelli
force-pushed
the
guess-datetime-format-np-str
branch
from
22f68a5
to
20e1960
Compare
mroeschke
approved these changes
Oct 6, 2022
|
Thanks @MarcoGorelli (Finally have the walrus operator in the code base!) |
Wave of the future! |
jbrockmendel
reviewed
Oct 6, 2022
| non_nan_elements = notna(arr).nonzero()[0] | ||
| if len(non_nan_elements): | ||
| return guess_datetime_format(arr[non_nan_elements[0]], dayfirst=dayfirst) | ||
| if type(first_non_nan_element := arr[non_nan_elements[0]]) is str: |
There was a problem hiding this comment.
is the fallback path for this less performant? could we instead cast np.str_ objs to str here?
There was a problem hiding this comment.
good call, have opened #48974 for now, will get back to it when I get a chance
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…nput (pandas-dev#48970) * BUG: to_datetime(..., infer_datetime_format=True) fails with np.str_ input * add return Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I haven't added a whatsnew note as this worked fine in the last released versions, it just fixes a regression introduced between releases so makes no difference to users
Same kind of thing as #45280