New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB: Unpin pydata sphinx theme #48285
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9bcfd81
WEB: Unpin pydata sphinx theme
phofl aa1f773
Remove parameter
phofl da7e4b6
Merge remote-tracking branch 'upstream/main' into web
phofl eae1651
Update
phofl 3bebd60
Update versions
phofl df77a05
Change urls
phofl 8bfd44b
Update doc/source/conf.py
phofl b76f513
Update doc/source/conf.py
phofl 80e25a5
Fix
phofl 04f7001
Merge remote-tracking branch 'upstream/main' into web
phofl 2c01cc4
Try url
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| <nav class="bd-links" id="bd-docs-nav" aria-label="Main navigation"> | ||
| <div class="bd-toc-item active"> | ||
| {% if pagename.startswith("reference") %} | ||
| {{ generate_nav_html("sidebar", maxdepth=4, collapse=True, includehidden=True, titles_only=True) }} | ||
| {{ generate_toctree_html("sidebar", maxdepth=4, collapse=True, includehidden=True, titles_only=True) }} | ||
| {% else %} | ||
| {{ generate_nav_html("sidebar", maxdepth=4, collapse=False, includehidden=True, titles_only=True) }} | ||
| {{ generate_toctree_html("sidebar", maxdepth=4, collapse=False, includehidden=True, titles_only=True) }} | ||
| {% endif %} | ||
| </div> | ||
| </nav> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,37 @@ | ||
| [ | ||
| { | ||
| "name": "dev", | ||
| "version": "docs/dev" | ||
| "version": "dev", | ||
| "url": "/docs/dev/" | ||
| }, | ||
| { | ||
| "name": "1.4 (stable)", | ||
| "version": "docs" | ||
| "version": "1.4 (stable)", | ||
| "url": "/docs/" | ||
| }, | ||
| { | ||
| "name": "1.4", | ||
| "version": "pandas-docs/version/1.4" | ||
| "version": "1.4", | ||
| "url": "/pandas-docs/version/1.4/" | ||
| }, | ||
| { | ||
| "name": "1.3", | ||
| "version": "pandas-docs/version/1.3" | ||
| "version": "1.3", | ||
| "url": "/pandas-docs/version/1.3/" | ||
| }, | ||
| { | ||
| "name": "1.2", | ||
| "version": "pandas-docs/version/1.2" | ||
| "version": "1.2", | ||
| "url": "/pandas-docs/version/1.2/" | ||
| }, | ||
| { | ||
| "name": "1.1", | ||
| "version": "pandas-docs/version/1.1" | ||
| "version": "1.1", | ||
| "url": "/pandas-docs/version/1.1/" | ||
| }, | ||
| { | ||
| "name": "1.0", | ||
| "version": "pandas-docs/version/1.0" | ||
| "version": "1.0", | ||
| "url": "/pandas-docs/version/1.0/" | ||
| } | ||
| ] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should add the logo for the dark site: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/branding.html#different-logos-for-light-and-dark-mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, I was checking https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/light-dark.html
Will build docs locally to check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this did not work. This path goes to _static. Tried to add the relative path from static to our svg, but this did not work either. So copied it over. Maybe you have a better solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange, I used the same as for the regular logo, I assumed it'd work in the same way. But I guess the original logo code is implemented by Sphinx, and the dark by the theme, so they may have differences.
Not ideal, but did you try to use the full https://pandas.pydata.org/... Path? If it works probably better than copying the image.
I'm in my phone now, I can have a look and see if looking at the theme code I can find a better solution. But I'm ok to have a copy of the logo if it's the only thing that works for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to give a relative path from the _static folder and this did not work. I think we don't want to load this from the web?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I didn't understand well before, sorry. I see what you mean here: https://github.com/pydata/pydata-sphinx-theme/blob/v0.10.1/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-logo.html#L16
My preference would be to load the image from the web actually. Given the options, simply using https://pandas.pydata.org/static/img/pandas_white.svg seems like the simplest option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that this works