New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Correct numeric_only default for resample var and std #47749

Merged

mroeschke merged 1 commit into pandas-dev:main from rhshadrach:resampler_numeric_only_default

Jul 16, 2022

Member

rhshadrach commented Jul 16, 2022

closes API: numeric_only consistency #46560 (Replace xxxx with the Github issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

No whatsnew since this was introduced in 1.5.0. The test would have caught it but it was explicitly passing numeric_only=lib.no_default instead of just not passing any arg.

As far as I know, this was the last task for #46560.


          BUG: Correct numeric_only default for resample var and std

c53c0ad

rhshadrach added Bug Numeric Operations Resample Nuisance Columns labels

rhshadrach added this to the 1.5 milestone

rhshadrach mentioned this pull request

API: numeric_only consistency #46560

Closed

9 tasks

mroeschke approved these changes

View reviewed changes

mroeschke merged commit 0a6be38 into pandas-dev:main

Member

mroeschke commented Jul 16, 2022

Awesome work @rhshadrach! This was a herculean effort 🎉

Member Author

rhshadrach commented Jul 18, 2022 •

edited

Thanks for all the reviews @mroeschke!

rhshadrach deleted the resampler_numeric_only_default branch

July 18, 2022 21:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment