ENH: Add numeric_only to window ops #47265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Enhancement
Window
9 tasks
rhshadrach
force-pushed
the
numeric_only_window
branch
from
e99e35a
to
8ac452c
Compare
mroeschke
reviewed
Jun 7, 2022
|
Doh - thanks @mroeschke; test added and implementation fixed for Series case. |
…ric_only_window
mroeschke
approved these changes
Jun 8, 2022
|
Awesome thanks @rhshadrach. Was this the final change for #46560? |
|
@mroeschke - I believe so, but going to be reviewing the API manually to double check things before closing that issue. Will report there and manually close if done. |
4 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* ENH: Add numeric_only to window ops * Fix corr/cov for Series; add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46560
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.