Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pre-commit autoupdate to fix CI #46558

Merged
merged 2 commits into from Mar 29, 2022

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Mar 29, 2022

new click release broke previous version of black, see psf/black#2964

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Mar 29, 2022
@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Mar 29, 2022
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarcoGorelli lgtm

OK to merge once Code Checks / pre-commit is green (locally OK so should be no different here)

@simonjayhawkins
Copy link
Member

I assume will will get the same error on 1.4.x?

@simonjayhawkins simonjayhawkins modified the milestones: 1.5, 1.4.2 Mar 29, 2022
@simonjayhawkins
Copy link
Member

I assume will will get the same error on 1.4.x?

hmm, merged #46550 a couple of hours ago after the problem was noticed on main. pre-commit was green on 1.4.x. more investigation required.

@MarcoGorelli
Copy link
Member Author

I think it's just that on the 1.4.x branch the run used the old cached dependencies:

Cache Size: ~63 MB (65887285 B)

which would've had the previous click version

Don't know how long the cache lasts, but I think this should probably be backported

@MarcoGorelli
Copy link
Member Author

OK to merge once Code Checks / pre-commit is green

merging then

@MarcoGorelli MarcoGorelli merged commit 8f44244 into pandas-dev:main Mar 29, 2022
@lumberbot-app

This comment was marked as resolved.

@MarcoGorelli
Copy link
Member Author

@meeseeksdev backport 1.4.x

@lumberbot-app

This comment was marked as resolved.

MarcoGorelli added a commit to MarcoGorelli/pandas that referenced this pull request Mar 29, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* pre-commit autoupdate

* update environment.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants