Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #39944 on branch 1.2.x (Fix regression for setitem not aligning rhs with boolean indexer) #39979

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #39944: Fix regression for setitem not aligning rhs with boolean indexer

@lumberbot-app lumberbot-app bot added this to the 1.2.3 milestone Feb 22, 2021
@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 22, 2021
@jreback
Copy link
Contributor

jreback commented Feb 22, 2021

Run source activate pandas-dev
mypy --version
mypy 0.782
Performing static analysis using mypy
pandas/tests/frame/indexing/test_setitem.py:408: error: Module has no attribute "setitem" [attr-defined]
pandas/tests/frame/indexing/test_setitem.py:408: error: Module has no attribute "loc" [attr-defined]
Found 2 errors in 1 file (checked 1129 source files)
Performing static analysis using mypy DONE
Error: Process completed with exit code 1.

@simonjayhawkins what do you want do here :-<

@simonjayhawkins simonjayhawkins merged commit 1325351 into pandas-dev:1.2.x Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants