CI clean pre-commit: upgrade isort, use correct file types in flake8 #37052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things here:
updating isort version
updating to use
types
instead offiles
(see Matching cython files: merge with python or support separately? pre-commit/pre-commit#1436 (comment) and Let pre-commit sort pxd files too PyCQA/isort#1549 (comment))removing
exclude: ^pandas/__init__\.py$|^pandas/core/api\.py$
as it's no longer necessaryreplacing
files: \.(pyx|pxd)$
withtypes: [cython]
:replacing the name
flake8-pxd
withflake8 (cython template)
, as that hook wasn't actually checking.pxd
files (theflake8-pyx
one was)