Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Sticky Headers in Table Visualization is broken in v1.5.0 #48644

Closed
1 task done
tehunter opened this issue Sep 19, 2022 · 8 comments · Fixed by #49811
Closed
1 task done

DOC: Sticky Headers in Table Visualization is broken in v1.5.0 #48644

tehunter opened this issue Sep 19, 2022 · 8 comments · Fixed by #49811
Labels
Bug Docs Styler conditional formatting using DataFrame.style
Milestone

Comments

@tehunter
Copy link
Contributor

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/pandas-docs/version/1.5.0/user_guide/style.html#Sticky-Headers

Documentation problem

Here is how the DataFrame looks in v1.5.0 documentation:
image

Here is how it looked in v1.4.4 documentation:
image

I'm using Firefox 104

Suggested fix for documentation

It seems that pydata-sphinx-theme.css is applying width: fit-content; to all tables. This should be overridden for this wide table.

This seems to be related to #48285

@tehunter tehunter added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 19, 2022
@mroeschke mroeschke added Styler conditional formatting using DataFrame.style and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 19, 2022
@mroeschke mroeschke added this to the 1.5.1 milestone Sep 19, 2022
@WooilKim
Copy link

Let me handle this.

@WooilKim
Copy link

take

@WooilKim
Copy link

I have a question.
Where can I find the document file in the repository?
I can not find it in docs directory.
Thanks.

@attack68
Copy link
Contributor

pandas/docs/source/user_guide/style.ipynb

@attack68
Copy link
Contributor

It seems like the whole notebook is mishandled, not just set_sticky.

@WooilKim
Copy link

@attack68
Thanks. I agree.

@WooilKim
Copy link

@attack68
I'm in hard time finding the css "fit-content". I think it is not in the style.ipynb file.
Can you give me an advice which file should I look into?
Thanks.

@attack68
Copy link
Contributor

FWIW I have detected that if one removes the width: fit-content; CSS attribute value pair from the default pydata-sphinx-theme.css then this page all works as previously. The previous 1.4.x pydata-sphinx-theme.css did not seem to have this width value set.

Screenshot 2022-11-20 at 15 21 58

An alternative solution to avoid tampering with the global pydata-sphinx-theme might be to try to encode an overwrite specifically on the userguide ipynb page. But I don't know how to do either of these at present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Docs Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants