Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix styles for dark mode in docs home #48527

Closed
datapythonista opened this issue Sep 13, 2022 · 19 comments · Fixed by #50936
Closed

DOC: Fix styles for dark mode in docs home #48527

datapythonista opened this issue Sep 13, 2022 · 19 comments · Fixed by #50936

Comments

@datapythonista
Copy link
Member

datapythonista commented Sep 13, 2022

xref: #42744

We'll be making the pandas documentation have a dark mode soon. But some boxes in the docs home seem to have a white background, instead of a transparent one:

Screenshot_20220913_143553

We should remove any custom style that is preventing the dark mode to work properly.

The changes can be tested against this branch to see if they work properly: #48285

@valanm22
Copy link

@datapythonista May I work on this issue?

@datapythonista
Copy link
Member Author

@datapythonista May I work on this issue?

Sure, please do. Thanks @valanm22

@valanm22
Copy link

Do I replace the old svg images or do I upload them as new svg images?

@datapythonista
Copy link
Member Author

Better replace the old images.

@valanm22
Copy link

Ok got it.

@thekavikumar
Copy link

I'll also try to fix it

thekavikumar added a commit to thekavikumar/pandas that referenced this issue Sep 13, 2022
@datapythonista datapythonista changed the title DOC: Fix svg images for dark mode DOC: Fix svg styles for dark mode in docs home Sep 13, 2022
@datapythonista
Copy link
Member Author

Looks like the problem are not the svg images, but the styles. I updated the description.

@datapythonista datapythonista changed the title DOC: Fix svg styles for dark mode in docs home DOC: Fix styles for dark mode in docs home Sep 13, 2022
thekavikumar added a commit to thekavikumar/pandas that referenced this issue Sep 13, 2022
@thekavikumar thekavikumar mentioned this issue Sep 13, 2022
7 tasks
@thekavikumar
Copy link

I'm not able to run python make.py HTML showing error module not found: No module named 'pandas._libs.interval
any solution?

@datapythonista
Copy link
Member Author

In the project root run ./setup.py build_ext --inplace to compile pandas extensions, that should fix it. In the contributing documentation you have all the info.

@thekavikumar
Copy link

That works! Now I will work on the styles and please do close this issue

@seanjedi
Copy link
Contributor

seanjedi commented Dec 1, 2022

Is this issue still open?
Seems to be resolved?

@datapythonista
Copy link
Member Author

The only thing I see that still doesn't show well in the dark mode is this section: https://pandas.pydata.org/docs/dev/getting_started/index.html#intro-to-pandas

We can close this issue when the background of that block is set to dark, and we check that things look good with it.

@anushkabishnoi
Copy link
Contributor

Hi I tried visiting the webpage you linked above, but since dark mode isn't released yet, it would be really helpful if you upload a screenshot of the portion to be modified. (willing to work on this issue :))

@datapythonista
Copy link
Member Author

The dark mode is released. If you don't have your browser in dark mode, you can get it with the icon in the right top of the docs.

@anushkabishnoi
Copy link
Contributor

oh okay, thanks

Can I work on this issue?

@anushkabishnoi
Copy link
Contributor

oh okay, thanks

Can I work on this issue?

This is my first time working with open source, it would be really helpful if you could guide me to files that need modification.

Thanks in advance :)

@datapythonista
Copy link
Member Author

Sure, thanks for the help. I think this PR should be similar to https://github.com/pandas-dev/pandas/pull/48572/files

You can build the documentation after creating an environment (see https://pandas.pydata.org/docs/dev/development/contributing_environment.html) running the make.py script inside doc/. The development documentation I point to has more detailed information.

@PKNaveen
Copy link

PKNaveen commented Mar 8, 2023

is this issue closed or still open?

@datapythonista
Copy link
Member Author

is this issue closed or still open?

There is a PR open, it'll be merge shortly. But there is #51860, which is related and you can work on if you are looking for something to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants