Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resend SIGTERM to reloader child process #2633

Closed
wants to merge 1 commit into from
Closed

feat: resend SIGTERM to reloader child process #2633

wants to merge 1 commit into from

Conversation

sim6
Copy link

@sim6 sim6 commented Apr 1, 2023 •
edited

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@sim6 sim6 force-pushed the feat_send_sigterm_to_reloader_child branch from 7f0e32d to a36d30d Compare April 1, 2023 23:44
@sim6
feat: resend SIGTERM to reloader child
20e079f 
Signed-off-by: Simó Albert i Beltran <sim6@bona.gent>
@sim6 sim6 force-pushed the feat_send_sigterm_to_reloader_child branch from a36d30d to 20e079f Compare April 1, 2023 23:45
@sim6 sim6 changed the title feat: send SIGTERM to reloader child feat: resend SIGTERM to reloader child Apr 1, 2023
@davidism davidism closed this Apr 2, 2023
@sim6
Copy link
Author

sim6 commented Apr 2, 2023

:(

@sim6 sim6 mentioned this pull request Apr 2, 2023
Closed
@sim6 sim6 changed the title feat: resend SIGTERM to reloader child feat: resend SIGTERM to reloader child process Apr 2, 2023
isardvdi pushed a commit to isard-vdi/isard that referenced this pull request Apr 14, 2023
@sim6
chore(api): werkzeug resends SIGTERM to reloader child process
135e029 
See also pallets/werkzeug#2633

Signed-off-by: Simó Albert i Beltran <sim6@bona.gent>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGTERM aren't sent to reloader child process
2 participants
@sim6 @davidism