New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update type annotation for `best_match` #2626

Merged

davidism merged 1 commit into pallets:main from JensHeinrich:feature/add-typing-override

Apr 3, 2023

JensHeinrich commented Mar 31, 2023

Tweak type annotations

fixes type annotation for best_match could be more accurate #2625

Checklist:

Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
Add or update relevant docs, in the docs folder and in code.
Add an entry in CHANGES.rst summarizing the change and linking to the issue.
Add .. versionchanged:: entries in any relevant code docs.
Run pre-commit hooks and fix any issues.
Run pytest and tox, no tests failed.

davidism changed the title ~~Feature/add typing override~~ update type annotation for best_match

davidism added this to the 2.3.0 milestone


          update type annotation for Accept.best_match

1acfd8f

davidism force-pushed the feature/add-typing-override branch from 7abf3a8 to 1acfd8f Compare

April 3, 2023 19:19

davidism marked this pull request as ready for review

April 3, 2023 19:19

davidism merged commit 6bae1de into pallets:main

10 checks passed

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.