-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Adapt expected traceback regexes for Python 3.11.0a1 #1527
Conversation
36dc0bc
to
7cb34db
Compare
7cb34db
to
ed9f08f
Compare
ed9f08f
to
c2031f6
Compare
Can you rebase this to 3.0.x branch? |
In a separate PR or here? |
Here, change the target of the PR by clicking "edit" next to the title, then do:
|
c2031f6
to
d5a436c
Compare
It made all the previously succeeded CI jobs fail with |
Looks like some problem on GitHub's side. I restarted the CI run and it's fine now. But I think we need to update our CI config to test against 3.10 and 3.11 as well... |
Pushed to see if it works. |
b691e64
to
ad66b79
Compare
It works 🎉 |
Fixes pallets#1526 Before: File ".../broken.html", line 2, in <module> {{ fail() }} File ".../test_debug.py", line 32, in <lambda> tmpl.render(fail=lambda: 1 / 0) ZeroDivisionError: division by zero After: File ".../broken.html", line 2, in <module> {{ fail() }} ^^^^^^^^^^^^ File ".../test_debug.py", line 32, in <lambda> tmpl.render(fail=lambda: 1 / 0) ~~^~~ ZeroDivisionError: division by zero
ad66b79
to
7577566
Compare
@davidism Thanks for merging and adapting the CI as well 🍷 |
Fixes #1526
Before:
After:
Checklist:
Add tests that demonstrate the correct behavior of the changethis is in testsAdd or update relevant docs, in the docs folder and in codethis is in tests and too early to declare Python 3.11 support in docsAdd an entry inadded but then removed per reviewCHANGES.rst
summarizing the change and linking to the issueAddthis is in tests.. versionchanged::
entries in any relevant code docspre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.