Explain AssertionError on the new @setupmethod 'shell_context_processor' behavior #4869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
HLFH
changed the title
for more information, see https://pre-commit.ci
|
I started to leave a review, but really this whole explanation is incorrect. You've misunderstood when and why modifying an app after setup is an error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appcontext updated doc explain the new @setupmethod 'shell_context_processor' behavior and gives guidance to developers so they can start refactoring their code and define the Flask application object under a basic application factory
create_appto avoid the AssertionError.@setupmethodbehavior #4868I think the updated doc page is still wrapped at 72 characters.
I don't think I need to an entry in CHANGES.rst or include .. versionchanged:: inline changelogs in relevant docstrings?