update some debug message behavior #4492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files
raises aDebugFilesKeyError
, it looks like the original error rather than a chained exception.on_json_loading_failed
tries to return thesuper()
implementation first, then reraises any error in debug mode.I originally started working on this due to pallets/werkzeug#2355, because I thought it might be better to not suppress JSON errors outside debug mode. 400 errors indicate a problem with client data, so it seems ok to show what that problem was. I've stopped short of doing that for this release, but want to revisit suppressing information in 400 errors later.