-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use compat fspath instead of os.fspath in static_folder #4049
Conversation
We do not support < 3.6 any longer (and neither does CPython). |
Line 54 in c04b0de
Is it documented somewhere that 1.1.x does not support < 3.6? |
We no longer support 1.1.x either, due to the magnitude of the 2.x release. Unfortunately, this snuck in when we made an unplanned 1.1.3 release to satisfy people who did not pin their dependencies. So we'd need to make another 1.1.4 release only to support Python versions that have not been supported for more than a year. |
Yeah, I understand not wanting to support EOL versions of Python, just seems like oversight that 1.1.3 introduced this breaking change, especially when there is a compat This is fine, it is your decision on how you want to support this, I should be able to work around this on my side without too much hassle, I'll just pin our 1.1.x testing to 1.1.2. If there are no more planned releases on 1.1.x then should be perfectly fine for our use case. |
I'll make another release. |
@davidism thanks, I really appreciate it. |
When 7ba35c4 was cherry-picked it introduced the usage of os.fspath which is not supported on Python <3.6
1.1.4 is available on PyPI |
@davidism thank you for the quick turn around time on this. |
When #3678 was merged it introduced the usage of os.fspath which is not supported on Python <3.6
This PR updates
static_folder
to use thefspath
from_compat
and un-skips the test case.Checklist:
[ ] Add or update relevant docs, in the docs folder and in code.CHANGES.rst
summarizing the change and linking to the issue.[ ] Add.. versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.