Use compat fspath instead of os.fspath in static_folder

[brettlangdon]

When #3678 was merged it introduced the usage of os.fspath which is not supported on Python <3.6

This PR updates static_folder to use the fspath from _compat and un-skips the test case.

• fixes AttributeError: 'module' object has no attribute 'fspath' #4050

Checklist:

• Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
• [ ] Add or update relevant docs, in the docs folder and in code.
• Add an entry in CHANGES.rst summarizing the change and linking to the issue.
• [ ] Add .. versionchanged:: entries in any relevant code docs.
• Run pre-commit hooks and fix any issues.
• Run pytest and tox, no tests failed.

[davidism]

We do not support < 3.6 any longer (and neither does CPython).

[brettlangdon]

setup.py in 1.1.x says python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*"

flask/setup.py

Line 54 in c04b0de

python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*",

Is it documented somewhere that 1.1.x does not support < 3.6?

[davidism]

We no longer support 1.1.x either, due to the magnitude of the 2.x release. Unfortunately, this snuck in when we made an unplanned 1.1.3 release to satisfy people who did not pin their dependencies.

So we'd need to make another 1.1.4 release only to support Python versions that have not been supported for more than a year.

[brettlangdon]

Yeah, I understand not wanting to support EOL versions of Python, just seems like oversight that 1.1.3 introduced this breaking change, especially when there is a compat fspath available.

This is fine, it is your decision on how you want to support this, I should be able to work around this on my side without too much hassle, I'll just pin our 1.1.x testing to 1.1.2. If there are no more planned releases on 1.1.x then should be perfectly fine for our use case.

[davidism]

I'll make another release.

[brettlangdon]

@davidism thanks, I really appreciate it.

[davidism]

1.1.4 is available on PyPI

[brettlangdon]

@davidism thank you for the quick turn around time on this.