Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Flask 2.0 #2439

Merged
merged 11 commits into from May 18, 2021
Merged

Add support for Flask 2.0 #2439

merged 11 commits into from May 18, 2021

Conversation

brettlangdon
Copy link
Member

Necessary changes to support Flask 2.0

Main difference the removal of internal _register_error_handler.

I also removed testing on ~=0.10.0 and ~=0.11.0 since those are quite old at this point (0.11.x was 2016).

@brettlangdon brettlangdon requested a review from a team as a code owner May 13, 2021 23:58
@brettlangdon
Copy link
Member Author

brettlangdon commented May 14, 2021

CI is blocked on pallets/flask#4049, or else we can only test with >=1.1.0,<1.1.3

Issue is resolved with Flask 1.1.4

Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly not bad to deal with considering the major bump! Just one nit 🙂

ddtrace/contrib/flask/patch.py Outdated Show resolved Hide resolved
jd
jd previously approved these changes May 14, 2021
@Kyle-Verhoog Kyle-Verhoog linked an issue May 14, 2021 that may be closed by this pull request
riotfile.py Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Vivet <nicolas@nzx.io>
@mergify mergify bot merged commit 4ac313b into master May 18, 2021
@mergify mergify bot deleted the brettlangdon/flask.2.0 branch May 18, 2021 20:19
@stevepentland stevepentland mentioned this pull request May 25, 2021
@Kyle-Verhoog Kyle-Verhoog added this to the 0.50.0 milestone May 25, 2021
@brettlangdon
Copy link
Member Author

@Mergifyio backport 0.49

mergify bot pushed a commit that referenced this pull request May 25, 2021
* Add support for Flask 2.0

* update riot flask versions

* use ~=1.1.0 again

* Update ddtrace/contrib/flask/patch.py

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>

* limit werkeug for flask-cache

* add release note

* Update riotfile.py

Co-authored-by: Nicolas Vivet <nicolas@nzx.io>

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Co-authored-by: Nicolas Vivet <nicolas@nzx.io>
(cherry picked from commit 4ac313b)
@mergify
Copy link
Contributor

mergify bot commented May 25, 2021

Command backport 0.49: success

Backports have been created

mergify bot added a commit that referenced this pull request May 25, 2021
* Add support for Flask 2.0

* update riot flask versions

* use ~=1.1.0 again

* Update ddtrace/contrib/flask/patch.py

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>

* limit werkeug for flask-cache

* add release note

* Update riotfile.py

Co-authored-by: Nicolas Vivet <nicolas@nzx.io>

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Co-authored-by: Nicolas Vivet <nicolas@nzx.io>
(cherry picked from commit 4ac313b)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flask 2.0 support
5 participants