New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Flask 2.0 #2439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue is resolved with Flask 1.1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly not bad to deal with considering the major bump! Just one nit 🙂
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
jd
previously approved these changes
May 14, 2021
Closed
nizox
reviewed
May 17, 2021
Co-authored-by: Nicolas Vivet <nicolas@nzx.io>
jd
approved these changes
May 17, 2021
P403n1x87
approved these changes
May 17, 2021
Closed
@Mergifyio backport 0.49 |
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2021
* Add support for Flask 2.0 * update riot flask versions * use ~=1.1.0 again * Update ddtrace/contrib/flask/patch.py Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> * limit werkeug for flask-cache * add release note * Update riotfile.py Co-authored-by: Nicolas Vivet <nicolas@nzx.io> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> Co-authored-by: Nicolas Vivet <nicolas@nzx.io> (cherry picked from commit 4ac313b)
Command
|
mergify bot
added a commit
that referenced
this pull request
May 25, 2021
* Add support for Flask 2.0 * update riot flask versions * use ~=1.1.0 again * Update ddtrace/contrib/flask/patch.py Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> * limit werkeug for flask-cache * add release note * Update riotfile.py Co-authored-by: Nicolas Vivet <nicolas@nzx.io> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca> Co-authored-by: Nicolas Vivet <nicolas@nzx.io> (cherry picked from commit 4ac313b) Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary changes to support Flask 2.0
Main difference the removal of internal
_register_error_handler
.I also removed testing on
~=0.10.0
and~=0.11.0
since those are quite old at this point (0.11.x was 2016).