New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of <stderr>
and <stdout>
mix in CliRunner
results
#2523
base: main
Are you sure you want to change the base?
Conversation
b98828a
to
7212e53
Compare
All the tests but the Other than that, this PR is ready to be reviewed or merged upstream. |
7212e53
to
4086bd3
Compare
4086bd3
to
095af46
Compare
PR has been rebased, all tests are passing. This PR is ready to be merged. |
7ae205d
to
8ab833c
Compare
Following the recent 8.1.4 release, this PR has been rebased and is ready to be reviewed/merged. |
497f9dd
to
073216d
Compare
All typing issues and conflicts have been fixed. The PR has been rebased on top of the latest This PR is ready to be merged for the upcoming Click 8.2.x. |
I think it makes more sense to deprecate/remove |
I like that. Let's remove it then. |
60d60f8
to
5d8ed45
Compare
|
5d8ed45
to
c13440e
Compare
Closes pallets#2522 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
147fe4d
to
b9c2580
Compare
FWIW, I think getting rid of mix_stderr makes sense. |
Thanks for chiming in on an obscure cleanup PR! 😁 |
This PR:
CliRunner
: restrictmix_stderr
influence to<output>
; keep<stderr>
and<stdout>
stable #2522result.stdout
always contain the pure output to<stdout>
. Never mangle<stderr>
in it.result.stderr
always contain the pure output to<stderr>
. Never raise an error.result.output
to be a perfect copy of what the user is expected to see in its terminal; i.e. produce a mix of<stdout>
and<stderr>
, in their natural order.mix_stderr
parameter fromCliRunner
.Checklist:
CHANGES.rst
summarizing the change and linking to the issue... versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.