Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'color' explicitly in error echoing #2273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dzcode
Copy link
Contributor

@dzcode dzcode commented May 2, 2022

  • This fixes the error reported in ctx.color is ignored in ClickException.show() #2193. Since the context has been popped at the point the error is printed, resolve_color_default incorrectly returns None and so the color is stripped from any color in error messages. This PR caches that setting in the ClickException initialization and then passes it to the echo later on, thereby bypassing this check at the failing point

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 8.2.0 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ctx.color is ignored in ClickException.show()
3 participants