Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use t.Mapping not t.Dict for parameters #2265

Merged
merged 5 commits into from May 8, 2023
Merged

Use t.Mapping not t.Dict for parameters #2265

merged 5 commits into from May 8, 2023

Commits on May 8, 2023

  1. Use t.Mapping not t.Dict for parameters 

    https://docs.python.org/3/library/typing.html#typing.Dict
> To annotate arguments it is preferred to use an abstract collection type such as Mapping.
    @altendky @saroad2
    altendky authored and saroad2 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    56c633a View commit details
    Browse the repository at this point in the history

  2. black

    @altendky @saroad2
    altendky authored and saroad2 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    e7da075 View commit details
    Browse the repository at this point in the history

  3. switch to MutableMapping

    @altendky @saroad2
    altendky authored and saroad2 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    c167167 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @saroad2
    pre-commit-ci[bot] authored and saroad2 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    97810d4 View commit details
    Browse the repository at this point in the history

  5. Add changenote in CHANGES.rst

    @saroad2
    saroad2 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    d45fd9d View commit details
    Browse the repository at this point in the history