Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in new AppEngine environments #1463

Merged
merged 1 commit into from Jan 31, 2020
Merged

Fix error in new AppEngine environments #1463

merged 1 commit into from Jan 31, 2020

Conversation

jab
Copy link
Member

@jab jab commented Jan 31, 2020

This commit was already merged to master in #1462. This PR targets the 7.x branch. Original PR description follows.


Newer AppEngine environments don't define the SERVER_SOFTWARE env variable. Without this change, importing click dies with a KeyError.

See related pull request for urllib3: urllib3/urllib3#1704

Newer AppEngine environments don't define the SERVER_SOFTWARE env variable. Without this change, importing click dies with a KeyError.

See related pull request for urllib3: urllib3/urllib3#1704
@jab jab merged commit a30a81e into pallets:7.x Jan 31, 2020
@jab jab deleted the 7.x branch January 31, 2020 01:34
@davidism davidism added this to the 7.1 milestone Jan 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants