Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging with log a default feature #62

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Make logging with log a default feature #62

merged 2 commits into from
Jun 25, 2022

Conversation

erik1p
Copy link
Contributor

@erik1p erik1p commented Jun 24, 2022

This change makes logging with the log crate a (default) feature but otherwise allows it, and the crate dependency, to be opted-out of by upstream consumers.

@erik1p
Copy link
Contributor Author

erik1p commented Jun 24, 2022

We don't allow using the log crate to steer internal developers toward our internal logging APIs which are hardened against leaking PII and secrets.

I'm hoping I can use your crate for some of my tests of interactions with global and/or mutually exclusive resources. There is one debug!(...) macro sinking my ship RN.

@palfrey
Copy link
Owner

palfrey commented Jun 24, 2022

Thanks for this. I've just added #63 to explicitly test with no default features which wasn't needed until now, but now there's a default feature here it's good to check that. If you could merge main into this just to double-check stuff, and then we can get this merged.

On a personal note I'm glad to see this potentially used by 1Password as myself and my spouse have been using your product for a few years now and we're happy users of it :)

@erik1p
Copy link
Contributor Author

erik1p commented Jun 24, 2022

I'm using it to test our crash reporting crate. I just overhauled it and added more testing around how it maintains its local crash report storage.

Glad to hear you love the app <3 Have you seen https://github.com/1Password/1password-teams-open-source ? I appreciate the work you and other contributors put into making the rust community as great as it is.

@palfrey
Copy link
Owner

palfrey commented Jun 25, 2022

Glad to hear you love the app <3 Have you seen https://github.com/1Password/1password-teams-open-source ? I appreciate the work you and other contributors put into making the rust community as great as it is.

Thanks. I hadn't seen that before. The Teams offer is generous, but doesn't quite cover what would actually be useful to me (a free Families account), so I've filed a bug about that

@palfrey
Copy link
Owner

palfrey commented Jun 25, 2022

FYI, 0.8.0 just got released with this and a couple of other features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants