Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

fix: add support for TypeScript 4.0 #4943

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

alan-agius4
Copy link
Contributor

Closes #4941

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @alan-agius4! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@alan-agius4 alan-agius4 force-pushed the ts4-support branch 3 times, most recently from f3cd994 to 727286e Compare July 23, 2020 13:47
@alan-agius4 alan-agius4 marked this pull request as ready for review July 23, 2020 13:52
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in @alan-agius4! The changes under src/ look good to me. Just hoping we can work around the major version change for tslib.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively 👍 from me, assuming nobody else has anything to say.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not upgrade to tslib 2.0

@alan-agius4 alan-agius4 force-pushed the ts4-support branch 2 times, most recently from e6baa9d to e45174d Compare July 29, 2020 08:31
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for not mentioning this earlier -- pinning to a beta version feels a little more stable than dev

package.json Outdated
@@ -73,7 +73,7 @@
"tslint-config-prettier": "^1.18.0",
"tslint-plugin-prettier": "^2.0.1",
"tslint-test-config-non-relative": "file:test/external/tslint-test-config-non-relative",
"typescript": "~3.8.2",
"typescript": "~4.0.0-dev.20200722",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use ~4.0.0-beta?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

align rule (and possibly others) broken with TypeScript 4.0.0-dev
4 participants