Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix regression in CheckstyleFormatter backwards compatibility #4561

Merged
merged 1 commit into from Mar 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/formatters/checkstyleFormatter.ts
Expand Up @@ -38,8 +38,8 @@ export class Formatter extends AbstractFormatter {
};
/* tslint:enable:object-literal-sort-keys */

public format(failures: RuleFailure[], _fixes: RuleFailure[], fileNames: string[]): string {
const groupedFailures: { [k: string]: RuleFailure[] } = {};
public format(failures: RuleFailure[], _fixes?: RuleFailure[], fileNames?: string[]): string {
const groupedFailures: { [fileName: string]: RuleFailure[] } = {};
for (const failure of failures) {
const fileName = failure.getFileName();
if (groupedFailures[fileName] !== undefined) {
Expand All @@ -49,6 +49,10 @@ export class Formatter extends AbstractFormatter {
}
}

if (fileNames === undefined) {
fileNames = Object.keys(groupedFailures);
}

const formattedFiles = fileNames.map(fileName => {
const formattedFailures =
groupedFailures[fileName] !== undefined
Expand Down
4 changes: 2 additions & 2 deletions src/language/formatter/abstractFormatter.ts
Expand Up @@ -23,8 +23,8 @@ export abstract class AbstractFormatter implements IFormatter {
public static metadata: IFormatterMetadata;
public abstract format(
failures: RuleFailure[],
fixes: RuleFailure[],
fileNames: string[],
fixes?: RuleFailure[],
fileNames?: string[],
): string;

protected sortFailures(failures: RuleFailure[]): RuleFailure[] {
Expand Down