Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add unknown as simple type to array-type #4433

Merged
merged 1 commit into from
Jan 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/rules/arrayTypeRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ function isSimpleType(nodeType: ts.TypeNode): boolean {
case ts.SyntaxKind.VoidKeyword:
case ts.SyntaxKind.NeverKeyword:
case ts.SyntaxKind.ThisType:
case ts.SyntaxKind.UnknownKeyword:
return true;
case ts.SyntaxKind.TypeReference:
// TypeReferences must be non-generic or be another Array with a simple type
Expand Down
4 changes: 4 additions & 0 deletions test/rules/array-type/array-simple/test.ts.fix
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,7 @@ interface FooInterface {
'.bar': {baz: string[];};
}

// Test an unknown Array
let t: unknown[] = [];
let u: unknown[] = [];

5 changes: 5 additions & 0 deletions test/rules/array-type/array-simple/test.ts.lint
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,9 @@ interface FooInterface {
'.bar': {baz: string[];};
}

// Test an unknown Array
let t: unknown[] = [];
let u: Array<unknown> = [];
~~~~~~~~~~~~~~ [0]

[0]: Array type using 'Array<T>' is forbidden for simple types. Use 'T[]' instead.
4 changes: 4 additions & 0 deletions test/rules/array-type/array/test.ts.fix
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,7 @@ interface FooInterface {
'.bar': {baz: string[];};
}

// Test an unknown Array
let t: unknown[] = [];
let u: unknown[] = [];

5 changes: 5 additions & 0 deletions test/rules/array-type/array/test.ts.lint
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,9 @@ interface FooInterface {
'.bar': {baz: string[];};
}

// Test an unknown Array
let t: unknown[] = [];
let u: Array<unknown> = [];
~~~~~~~~~~~~~~ [0]

[0]: Array type using 'Array<T>' is forbidden. Use 'T[]' instead.
4 changes: 4 additions & 0 deletions test/rules/array-type/generic/test.ts.fix
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,7 @@ interface FooInterface {
'.bar': {baz: Array<string>;};
}

// Test an unknown Array
let t: Array<unknown> = [];
let u: Array<unknown> = [];

5 changes: 5 additions & 0 deletions test/rules/array-type/generic/test.ts.lint
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,9 @@ interface FooInterface {
~~~~~~~~ [0]
}

// Test an unknown Array
let t: unknown[] = [];
~~~~~~~~~ [0]
let u: Array<unknown> = [];

[0]: Array type using 'T[]' is forbidden. Use 'Array<T>' instead.